Add grammar support for insert...returning... (most cases)#419
Merged
angelamayxie merged 6 commits intomainfrom Jun 4, 2025
Merged
Add grammar support for insert...returning... (most cases)#419angelamayxie merged 6 commits intomainfrom
insert...returning... (most cases)#419angelamayxie merged 6 commits intomainfrom
Conversation
insert...returning...
insert...returning...insert...returning... (most cases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of dolthub/dolt#9248
Insert...returning...statements work withinsert_data_aliasandSET assignment_listcases. The following examples (from the MariaDB documentation) work.I wasn't able to get
insert...returning...to work withinsert_data_selectcases. TheRETURNINGclause is not supported for the following and would lead to a syntax error.When I had added a
RETURNINGclause, there was a grammar conflict because the parser was not able to distinguish between a column alias and the 'RETURNING' keyword. This could be resolved by makingRETURNINGa reserved keyword, but we decided against that sinceRETURNINGis a non-reserved keyword in MySQL (doc).I ran into a similar conflict with
insert_data_aliascases because the parser was not able to distinguish between a table alias and theRETURNINGkeyword. This was resolved by addingRETURNINGtonon_reserved_keyword2. This meansRETURNINGcan't be used as a table alias and may cause some customer issues but the likelihood is very low.Also removed TestSingle from parse_test.go (we already have TestSingleSQL)